Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change selected on View to selectionStyle #61

Open
wkiefer opened this issue Jun 8, 2017 · 0 comments
Open

Change selected on View to selectionStyle #61

wkiefer opened this issue Jun 8, 2017 · 0 comments
Assignees
Milestone

Comments

@wkiefer
Copy link
Contributor

wkiefer commented Jun 8, 2017

selected has issues when you subclass an Objective-C NSView or UIView with an isSelected getter (example is NSTableRowView) and also conform it to View.

The synthesized swift name (isSelected) cannot coexist with the View conformance selected.

This seemed to work ok in Swift <3.2, but no longer works in Swift 3.2+.

We should move this to an emum of selectionStyle to match highlightStyle. This will also give us a bit more flexibility in types of selection state.

We should also give NSView and UIView classes that have a selected property easy free implementations of selectionState.

This is a breaking change.

@wkiefer wkiefer self-assigned this Jun 8, 2017
@wkiefer wkiefer added this to the 1.0 milestone Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant