Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module name and readme #2

Open
Richardjmorton opened this issue Oct 19, 2021 · 1 comment
Open

Module name and readme #2

Richardjmorton opened this issue Oct 19, 2021 · 1 comment

Comments

@Richardjmorton
Copy link

Hi,

I now know a few who have struggled with starting to use this package. I just wanted to make a couple of suggestions that would help with basic issues.

First, the module when downloaded is stored in the folder named 'image-noise-gate'. If using a single location for python modules (that is scanned for existing modules, e.g. by it being in your PYTHON_PATH), then this folder name cannot be imported as a module, i.e. from image-noise-gate.noisegate import noise_gate_batch does not work. This is due to the hyphens. So I would change this to underscores.

Second, those not familiar with Cython (like myself) struggle to get started. I would add a couple of lines more to the readme that discuss building the module, and maybe an example import statement. Happy to add these myself and make a pull request.

@ebuchlin
Copy link

More detailed instructions would indeed be useful. Here is what I have done (Ubuntu):

  • Install the cython3 system package
  • Run python setup.py install --user
  • Import by from noisegate.tools import noise_gate_batch. Just import noisegate does not import anything, this seems to be because the__init__.py is not copied by setup.py to the installation directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants