Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue trying to
pip install
this package. The issue is not thatfitz
isn't listed, but the keyword forrequires
should actually beinstall_requires
. Without this keyword,pip
actually won't install transitive dependencies.Since the original installation instructions recommended a
git clone
followed by pip install, I modified the README to demonstrate a faster installation that combines both steps, assuming theinstall_requires
keyword is in place. Also, as already mentioned by another user, having arequirements.txt
that doesn't pin versions is duplicitous of theinstall_requires
, but I'll leave that to you to remove if you want.Furthermore, this seems like a good package to go up on PyPI, so that users can simply
pip install termpdf.py
. If there's interest for that, I'd be happy to contribute a separate PR that would move the repo tosetuptools
orpoetry
that would simplify the build/distribution process a lot.To see an example of the installation I wrote in the
README.md
, you could try it from my branch: