Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[possible typo] AdaptiveAvgPool2d or AdaptiveMaxPool2d in NiN? #104

Open
Fengyee opened this issue Mar 2, 2020 · 1 comment
Open

[possible typo] AdaptiveAvgPool2d or AdaptiveMaxPool2d in NiN? #104

Fengyee opened this issue Mar 2, 2020 · 1 comment

Comments

@Fengyee
Copy link

Fengyee commented Mar 2, 2020

in Ch09_Modern_Convolutional_Networks/Network_in_Network(NiN).ipynb defines the NiN net model with:

    #Global Average Pooling can be achieved by AdaptiveMaxPool2d with output size = (1,1)
    self.avg1 = nn.AdaptiveMaxPool2d((1,1))

Is it a typo of nn.AdaptiveAvgPool2d or some deeper reasons behind this? Cause using Avg will train a lot slower and get bad train/val accuracy like 0.460 (epoch 5)

@AnirudhDagar
Copy link
Member

Yes, that's a typo in the notebook. Thanks for pointing it out. Would you like to send in a PR fixing it and updating the results after running the notebook?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants