Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention that components are in a separate repo (and provide insight into why) #481

Open
travi opened this issue Oct 28, 2019 · 3 comments
Open

Comments

@travi
Copy link
Member

travi commented Oct 28, 2019

No description provided.

@micleners
Copy link
Member

Can you add more detail here?

I was wondering about this from the PR feedback on 404 page.

Would you envision a component in components be built to style the 404 page or will we start to build components in site too, for new layouts?

@travi
Copy link
Member Author

travi commented Nov 2, 2019

the intent is for anything visible as a component would be in the components package. the site would need to import from that package into whatever is necessary to wire the component into gatsby or pass it the results of the data query.

in the 404 example, the site side would mostly just import the component and render it, but the actual visual parts should come from the package. i'm fine with merging something simple directly into the site to start with, but would want us to follow that up to extract the actual component.

does that help?

@micleners
Copy link
Member

Yes, I think this process makes sense. Explaining this for folks coming on to contribute is a good idea (since this paradigm was not readily apparent to me) 👍I support this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants