AttributeError when Author is None

[TylerGubala]

OS: Windows 10 64bit
Python version: 3.5-32
PySvn version: 0.3.46

When attempting to list files in extended mode (extended=True) or recursively, an exception is thrown when the commit_node.find('author') is None.

Example:

#! /usr/bin/python
# -*- coding: utf-8 -*-
"""Basic example of issue where author nodes not being found breaks svn functionality
"""
from svn.remote import RemoteClient as SvnRepo  
blendersvn = SvnRepo("https://svn.blender.org/svnroot/bf-blender/")

for tag in blendersvn.list_recursive(rel_path="/tags"): 
     print(tag)

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\TGubs\Code\Python\bpymaketest\venvs\3.5-32\lib\site-packages\svn\common.py", line 396, in list_recursive
    for entry in self.list(extended=True, rel_path=current_rel_path):
  File "C:\Users\TGubs\Code\Python\bpymaketest\venvs\3.5-32\lib\site-packages\svn\common.py", line 363, in list
    author = commit_node.find('author').text
AttributeError: 'NoneType' object has no attribute 'text'

#! /usr/bin/python
# -*- coding: utf-8 -*-
"""Basic example of issue where author nodes not being found breaks svn functionality
"""
from svn.remote import RemoteClient as SvnRepo  
blendersvn = SvnRepo("https://svn.blender.org/svnroot/bf-blender/")

for tag in blendersvn.list(rel_path="/tags", extended=True): 
     print(tag)

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\TGubs\Code\Python\bpymaketest\venvs\3.5-32\lib\site-packages\svn\common.py", line 363, in list
    author = commit_node.find('author').text
AttributeError: 'NoneType' object has no attribute 'text'

Possibly related is a pull request from 2017 and issue #89

[mtHB]

I ran into the same problem. Have you found a solution @TylerGubala?

In common.py I added

try:
     author = commit_node.find('author').text
except AttributeError:
     author = None

as a quick fix for me. I am currently not sure what kind of impact this will have but for now its fine I guess...

[TylerGubala]

My "solution" basically amounts to avoiding commits where the author is returned as None. I also have not looked very deeply into it. Hope you find better success!

…

On Mon, Nov 23, 2020, 5:52 AM mtHB ***@***.***> wrote: I ran into the same problem. Have you found a solution @TylerGubala <https://github.com/TylerGubala>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#140 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFLEYR4NUY5E5A7P3VWOR33SRI5IJANCNFSM4ISUWRXQ> .

[mtHB]

@TylerGubala You should not avoid commits where author is None.
While implementing the log_default method by myself I found out that a merge commit does not need a author.
The project I am working on does need an information like that.