Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version number hard coded #336

Closed
MMCMA opened this issue Jul 25, 2023 · 1 comment · Fixed by #342
Closed

Version number hard coded #336

MMCMA opened this issue Jul 25, 2023 · 1 comment · Fixed by #342

Comments

@MMCMA
Copy link

MMCMA commented Jul 25, 2023

If I am not mistaken - the version number in init is hard coded - and currentl set to the wrong version. I can recommend adding versioneer which should take care of this automatically.
@dswah dswah linked a pull request Feb 8, 2024 that will close this issue
use dynamic versioning #342
Merged
@dswah
Copy link
Owner

dswah commented Feb 8, 2024

thank you for pointing this out!
this is very confusing.

i am fixing with poetry-dynamic versioning, which uses git tags to figure out the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use dynamic versioning dswah/pyGAM
2 participants
@MMCMA @dswah