Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make compatible with bevy@~0.14 #23

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat!: make compatible with bevy@~0.14 #23

wants to merge 3 commits into from
+22 −19

Conversation

waynevanson
Copy link

@waynevanson waynevanson commented Sep 6, 2024 •
edited
Loading

I got close but not close enough, using the branch https://github.com/mkrasnitski/pixels from the PR parasyte/pixels#391 via the patches in cargo.

I can't figure out the error in src/system.rs.
It says that the window we get on line 33 doesn't have the trait HasWindowHandle.
I believe it should be on there because we've added the feature rwh_06.

Feel free to add to or change this as you wish!

@waynevanson waynevanson changed the title feat!: make compatible with bevy@~14 feat!: make compatible with bevy@~0.14 Sep 6, 2024
@parasyte
Copy link
Contributor

FWIW, parasyte/pixels#391 was merged today.

@dtcristo
Copy link
Owner

FWIW, parasyte/pixels#391 was merged today.

Thanks @parasyte! I'll look at getting bevy_pixels working with bevy 0.14 and pixels 0.14.

@parasyte
Copy link
Contributor

I haven't yet published a pixels release that supports wgpu 0.19, but I will be glad to if it will unblock this PR.

@dtcristo
Copy link
Owner

I haven't yet published a pixels release that supports wgpu 0.19, but I will be glad to if it will unblock this PR.

@parasyte Ahh, so the new release of pixels 0.14 just bumps to wgpu 0.17 while it's the PR you mentioned that brings you to wgpu 0.19 with support for raw-window-handle 0.6 (yet to be included in a release)? I just noticed pixels 0.14 was just released and assumed it was included.

It would be nice to get this into a release, but no rush. More than happy to wait until those changes have been battle tested first.

@dc740
Copy link

dc740 commented Nov 24, 2024

is there anything else blocking the upgrade? We just need a new version of pixels to bump the version. right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot upgrade to bevy 0.14
4 participants
@waynevanson @parasyte @dtcristo @dc740