-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated output #40
Comments
Can you try this for me: After starting the app, press [enter] a few times, and then do the I had noticed a bug that the first output is doubled, earlier. Maybe this is the same thing. |
yup same result after many returns |
K looking into it. |
it has something to do with the input. after a few commands I start getting breaking on each character as i type dive~$ s |
Hmm. If your vantage code is small, could you please paste it here? Also, what terminal are you using? |
Using the above, I too am experiencing the same as @wonderdogone. What I've found is the vertical height of the terminal determines this behavior, see below. Too tall of terminalTerminal just tall enough
|
@G3E9 you nailed it. That's so weird. It's not so much the terminal height, as the cursor has to be on the bottom of the page. Going to look into this soon. |
Yeah - I was able to reproduce it. Thanks. Vorpal just recently switched to a newer version of inquirer (10x smaller), and this broke a bunch of things. This looks like the last thing left. |
Right on. While I was just about to test with Vorpal, you sound like your on top of it!.. I've really been enjoying Vantage in my projects, awesome work! |
Thanks! Really glad you find it helpful! |
yea I figured out its happening most of the time in the morning when i open a new terminal and cursor is at the top. |
This is fixed in Vorpal - I just have to migrate Vantage to the latest version of Vorpal. |
I'm seeing this issue, is there any fix? |
I only see it when I connect from another process and I found that just typing PS C:\code\bin\shar> vantage
local@mycomputer~$ vantage myserver:port
my-vantage-prompt> |
@samhagman the version of vorpal that vantage uses was brought up to date in #62 , by any chance was this issue fixed? I haven't noticed the issue in my own work. cc @dthree |
@zakhenry I believe this was fixed. |
when you run the simple example like
var vantage = require("vantage")();
// Add the command "foo", which logs "bar".
vantage
.command("foo")
.description("Outputs 'bar'.")
.action(function(args, callback) {
this.log("bar");
callback();
});
vantage
.delimiter("websvr~$")
.listen(5003)
.show();
and you type foo, you get foo repeated then bar. Why is foo repeating?
websvr~$ foo
websvr~$ foo (this is the repeated output)
bar
The text was updated successfully, but these errors were encountered: