Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect end position in a lot of nodes #27

Open
duaraghav8 opened this issue Jan 23, 2018 · 0 comments
Open

Incorrect end position in a lot of nodes #27

duaraghav8 opened this issue Jan 23, 2018 · 0 comments

Comments

@duaraghav8
Copy link
Owner

A lot of definitions in the grammar are similar to

id:Identifier __ params:("(" __ InformalParameterList? __ ")")?

Notice that the first whitespace directive __ should exist inside params rather than before it. here, it exists before it. This means in a code construct like

contract Foo is bar, baz                         {
}

the end position of the Modifier baz actually covers al the whitespace after baz instead of just covering till z. This is a problem with lot of node definitions where everything after the whitespace __ is optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant