text zoom improvements #3509
Merged
text zoom improvements #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blocking assets publisher
# Conflicts: # Core/UserDefaultsPropertyWrapper.swift # DuckDuckGo/AppDelegate.swift # DuckDuckGo/MainViewController.swift # DuckDuckGo/TabManager.swift # DuckDuckGo/TabViewController.swift # DuckDuckGo/TabViewControllerLongPressMenuExtension.swift
|
…ove entry from storage
# Conflicts: # Core/FeatureFlag.swift # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/AppDelegate.swift
DuckDuckGo/TextZoomEditorView.swift
Outdated
| .padding(12) | ||
| .padding(.trailing, 8) | ||
| } | ||
| .background(RoundedRectangle(cornerRadius: 8).foregroundColor(Color(designSystemColor: .surface))) |
There was a problem hiding this comment.
Suggested change
| .background(RoundedRectangle(cornerRadius: 8).foregroundColor(Color(designSystemColor: .surface))) | |
| .background(RoundedRectangle(cornerRadius: 8) | |
| .foregroundColor(Color(designSystemColor: .surface))) |
ankushkushwaha
approved these changes
Nov 12, 2024
miasma13
approved these changes
Nov 12, 2024
# Conflicts: # Core/FeatureFlag.swift # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGoTests/MockFeatureFlagger.swift
brindy
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 14, 2024
**Required**: Task/Issue URL: https://app.asana.com/0/inbox/392891325557408/1206268893832417/1208690165365832 iOS PR: duckduckgo/iOS#3509 macOS PR: duckduckgo/macos-browser#3496 What kind of version bump will this require?: Major **Optional**: Tech Design URL: CC: **Description**: Adds feature flag for text zoom. See platform PRs for testing.
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGoTests/MockFeatureFlagger.swift
samsymons
added a commit
that referenced
this pull request
Nov 14, 2024
# By Daniel Bernal (3) and others # Via GitHub * main: Remove the `ld_classic` build setting (#3575) text zoom improvements (#3509) Add support for local overrides for feature flags (#3571) pixels for bookmarks > favorites tab (#3572) Sync BSK with macos (#3561) Add possibility to stop page loading (#3553) [DuckPlayer] Overlay Usage Pixels (#3565) Update pr.yml Update pr.yml # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
mgurgel
pushed a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 18, 2024
**Required**: Task/Issue URL: https://app.asana.com/0/inbox/392891325557408/1206268893832417/1208690165365832 iOS PR: duckduckgo/iOS#3509 macOS PR: duckduckgo/macos-browser#3496 What kind of version bump will this require?: Major **Optional**: Tech Design URL: CC: **Description**: Adds feature flag for text zoom. See platform PRs for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1206268893832417/f
Tech Design URL:
CC:
Description:
Makes it easier to access text zoom and allows per page state.
Steps to test this PR:
See test scenarios in Ship Review: https://app.asana.com/0/0/1208685664909495/f
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template