Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text zoom improvements #3509

Merged
merged 42 commits into from
Nov 14, 2024
Merged

text zoom improvements #3509

merged 42 commits into from
Nov 14, 2024

Commits on Oct 23, 2024

  1. add page zoom menu option and fix dependency on AppDependencyProvider… 

    … in TabManager
    @brindy
    brindy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f869419 View commit details
    Browse the repository at this point in the history

  2. fix settings bug and retain cycle and remove unneed input to content … 

    …blocking assets publisher
    @brindy
    brindy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    866c271 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. migrate to using default zoom level rather than text size

    @brindy
    brindy committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d9d1e4e View commit details
    Browse the repository at this point in the history

  2. clean up settings and use an enum for the zoom levels

    @brindy
    brindy committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8a1e890 View commit details
    Browse the repository at this point in the history

  3. more renaming

    @brindy
    brindy committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2d3b907 View commit details
    Browse the repository at this point in the history

  4. show slide sheet on phone

    @brindy
    brindy committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    256ec20 View commit details
    Browse the repository at this point in the history

  5. fix ui glitch

    @brindy
    brindy committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d43a56c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge branch 'main' into brindy/easier-page-zoom

    @brindy
    brindy committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d4e968e View commit details
    Browse the repository at this point in the history

  2. restore global settings in script

    @brindy
    brindy committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a52dbf1 View commit details
    Browse the repository at this point in the history

  3. extract code into own files and tweakk UI

    @brindy
    brindy committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6bee1ce View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Design check in feedback and enable on iPad

    @brindy
    brindy committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    10b121e View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. move forget text zoom to right place

    @brindy
    brindy committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e31637e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. disable on ipad

    @brindy
    brindy committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e1b6cd3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into brindy/easier-page-zoom 

    # Conflicts:
#	Core/UserDefaultsPropertyWrapper.swift
#	DuckDuckGo/AppDelegate.swift
#	DuckDuckGo/MainViewController.swift
#	DuckDuckGo/TabManager.swift
#	DuckDuckGo/TabViewController.swift
#	DuckDuckGo/TabViewControllerLongPressMenuExtension.swift
    @brindy
    brindy committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    cb39cb8 View commit details
    Browse the repository at this point in the history

  3. add pixels

    @brindy
    brindy committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    cb76df3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into brindy/easier-page-zoom

    @brindy
    brindy committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2ec09c8 View commit details
    Browse the repository at this point in the history

  5. swift lint and a compile error

    @brindy
    brindy committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8a5c093 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. use correct pixel parameters

    @brindy
    brindy committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    836e30b View commit details
    Browse the repository at this point in the history

  2. add mock domain text level storage

    @brindy
    brindy committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fe7329a View commit details
    Browse the repository at this point in the history

  3. handle landsape better

    @brindy
    brindy committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    78623cc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into brindy/easier-page-zoom

    @brindy
    brindy committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    067d5aa View commit details
    Browse the repository at this point in the history

  5. create coordinator to handle all interactions with text zoom

    @brindy
    brindy committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c87d7d0 View commit details
    Browse the repository at this point in the history

  6. remove textsize js

    @brindy
    brindy committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    36301c5 View commit details
    Browse the repository at this point in the history

  7. show percent in menu when appropriate. if set back to app default rem… 

    …ove entry from storage
    @brindy
    brindy committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a8c4ef2 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. fix tests

    @brindy
    brindy committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    06a128d View commit details
    Browse the repository at this point in the history

  2. unit tests for text zoom coordinator

    @brindy
    brindy committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b6e0461 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'main' into brindy/easier-page-zoom 

    # Conflicts:
#	Core/FeatureFlag.swift
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/AppDelegate.swift
    @brindy
    brindy committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8431f65 View commit details
    Browse the repository at this point in the history

  2. swiftlint

    @brindy
    brindy committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2dd2aa4 View commit details
    Browse the repository at this point in the history

  3. update settings footer for text zoom

    @brindy
    brindy committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    24ebae7 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. fix ipad bug where it disables the ui

    @brindy
    brindy committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7bed09e View commit details
    Browse the repository at this point in the history

  2. update from ship review

    @brindy
    brindy committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8f365e6 View commit details
    Browse the repository at this point in the history

  3. tweak code layout

    @brindy
    brindy committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    254015d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. address bar setting should not be visible on ipad

    @brindy
    brindy committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    620a649 View commit details
    Browse the repository at this point in the history

  2. merge main, fix conflicts, bump bsk

    @brindy
    brindy committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a14e301 View commit details
    Browse the repository at this point in the history

  3. fix problem where if item is disabled then footer text would still be… 

    … visible for both items
    @brindy
    brindy committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    16d3078 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. fix setting when voice search not available

    @brindy
    brindy committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bae1e61 View commit details
    Browse the repository at this point in the history

  2. remove unused notification listener since no user script exists now

    @brindy
    brindy committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    feea52b View commit details
    Browse the repository at this point in the history

  3. complete rename to text size and remove dead code

    @brindy
    brindy committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    274aafd View commit details
    Browse the repository at this point in the history

  4. remove weird xcode token

    @brindy
    brindy committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bcd14bb View commit details
    Browse the repository at this point in the history

  5. fix pixel names

    @brindy
    brindy committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f6ef130 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Merge branch 'main' into brindy/easier-page-zoom 

    # Conflicts:
#	Core/FeatureFlag.swift
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGoTests/MockFeatureFlagger.swift
    @brindy
    brindy committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d2f6ab4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into brindy/easier-page-zoom 

    # Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGoTests/MockFeatureFlagger.swift
    @brindy
    brindy committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    de126b3 View commit details
    Browse the repository at this point in the history