Hi FrankenPHP Team, I might be wrong but I might have found a typo in the docs of worker mode of FrankenPHP

[alexandreelise]

Hi Kevin,

frankenphp/docs/worker.md

Line 83 in 2055142

} while ($running && !(isset($_SERVER['MAX_REQUESTS']) && ++$nbRequests >= $_SERVER['MAX_REQUESTS']));

I might be wrong but it seems that it should be ++$nbRequests <= $_SERVER['MAX_REQUESTS'] because it seems you want to break out of the loop when max requests is reached. But I might miss something.

[nickchomey]

I think you might be right. Moreover, am I wrong to think that the 2nd clause
!(isset($_SERVER['MAX_REQUESTS']) makes the 3rd one redundant/impossible? If max requests isn't set, how could the <= check even be evaluated?

But perhaps I, too, am missing something.

[dunglas]

Good catch, would you mind opening a PR to fix the docs?

[alexandreelise]

@dunglas No problem Kevin, I wanted to discuss it first as I might be wrong and didn't want to be a hassle. Doing the PR now.

[alexandreelise]

Hi Kevin,
Pull request is done. While I was at it I found something that seems to be a "defect" in the ci. Just a missing METADATA key leading to null image hence failing the amd64 binary build step.
the METADATA key missing seems to be

'."static-builder"."containerimage.config.digest"'

[alexandreelise]

Wow! Nice one @nickchomey,

That's why code review and pair programming is better to look at the code with many different views and eyes!

Thanks! I fixed it in the PR.