fix: SIGSEGV when an env var is empty #1271
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right, the documentation states that it can return nil. I think we were also pinning empty strings before #1137, maybe this is due to a newer go version? I'll see if I can reproduce it somehow |
AlliBalliBaba
approved these changes
Dec 20, 2024
|
I am only able to recreate the segfault by explicitly pinning a constant string like this: |
|
Or wait, not even then am I seeing the segmentation violation. Maybe we should add fuzzing tests for the environment as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1269.
The behavior of
unsafe.StringData()is undefined when the string is empty.