Attempt to make chat more reliable #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duogenesis
force-pushed
the
application-level-keepalives
branch
2 times, most recently
from
63574ae
to
f7bf839
Compare
duogenesis
force-pushed
the
application-level-keepalives
branch
from
f7bf839
to
9f16b39
Compare
duogenesis
force-pushed
the
application-level-keepalives
branch
from
d2583e7
to
2bab5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that this issue is partly to blame for the poor reliability of chat in Duolicious: xmppjs/xmpp.js#902 I also suspect that the Duolicious chat server's reliability is poor.
In any case, we can probably just add some retries and recreate chat clients when the server comes out of the inactive state.
Changes:
Increase reconnection delay - This prevents clients from DDoSing the server when it goes down then comes back online. Ideally the XMPP library we use (xmpp.js) would support exponential back-off, but it doesn't.
Recreate the xmpp.js client when the app comes out of the background state on mobile.
Show a spinner on the inbox tab when temporarily offline
Use an application-level ping mechanism to determine if the server can be contacted. This should be supported at the transport later seeing as we use websockets. Though some random Stack Exchange post said there's inconsistency between the behavior of different browsers with respect to websocket pings.