Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental rate limiter on non-broadcast messages #1404

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

goshawk-3
Copy link
Contributor

fixes #1402

For the present, this PR should be used on testing rate limiter on devnet.

@codecov-commenter
Copy link

Codecov Report

Merging #1404 (4da99dd) into master (828364b) will decrease coverage by 9.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1404      +/-   ##
==========================================
- Coverage   50.51%   41.33%   -9.18%     
==========================================
  Files         145      144       -1     
  Lines        7544     9434    +1890     
==========================================
+ Hits         3811     3900      +89     
- Misses       3066     4904    +1838     
+ Partials      667      630      -37     
Impacted Files Coverage Δ
pkg/core/consensus/testing/node.go 0.00% <0.00%> (-93.55%) ⬇️
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/testing/utils.go 0.00% <0.00%> (-75.61%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/gql/query/transactions.go 13.43% <0.00%> (-52.55%) ⬇️
pkg/util/nativeutils/eventbus/eventbus.go 57.14% <0.00%> (-42.86%) ⬇️
pkg/rpc/client/session.go 26.19% <0.00%> (-42.39%) ⬇️
pkg/rpc/client/client.go 3.73% <0.00%> (-36.61%) ⬇️
pkg/core/consensus/reduction/aggregator.go 56.25% <0.00%> (-35.06%) ⬇️
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21bb7e...4da99dd. Read the comment docs.

@goshawk-3 goshawk-3 changed the title Add experimental rate limiter non-broadcast messages Add experimental rate limiter on non-broadcast messages May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mitigate pressure on socket send buffer
3 participants