Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API to access inner jubjub-point in PublicKey #13

Open
moCello opened this issue Apr 22, 2024 · 0 comments
Open

Improve API to access inner jubjub-point in PublicKey #13

moCello opened this issue Apr 22, 2024 · 0 comments

Comments

@moCello
Copy link
Member

moCello commented Apr 22, 2024

Summary

Find a better way to access the underlying jubjub-elements than with as_ref (e.g. introducing an inner method).

Originally posted by @ureeves in dusk-network/phoenix#157 (comment)

Adding my two cents here. I think having a StealthAddress::address function is a bit... redundant to say the least, and confusing in the worst case. That said, I also understand the stealth_address.note_pk().as_ref() is unsatisfactory.

Maybe we should improve the access to the underlying JubJubScalar in NotePublicKey in a future PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant