Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Wallet object in MoatContext #69

Closed
xevisalle opened this issue Jan 30, 2024 · 1 comment
Closed

Use Wallet object in MoatContext #69

xevisalle opened this issue Jan 30, 2024 · 1 comment
Assignees
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@xevisalle
Copy link
Member

Summary

Right now we are using the path to the wallet and the password in MoatContext. We need to use the wallet object itself, instead. Like this, the wallet object can be used across functions without depending on a disk file. This will be suitable to improve the API for the web app.

@xevisalle xevisalle self-assigned this Jan 30, 2024
@xevisalle xevisalle linked a pull request Jan 30, 2024 that will close this issue
@HDauven HDauven added the type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) label Apr 10, 2024
@xevisalle
Copy link
Member Author

Closing since we are porting all the Citadel-related code to the citadel repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants