One instance per contract function call #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
requested review from
miloszm,
fed-franz,
HDauven,
moCello and
herr-seppia
and removed request for
miloszm,
fed-franz,
HDauven,
moCello and
herr-seppia
ureeves
force-pushed
the
single-instance-per-call
branch
2 times, most recently
from
2509e52 to
1e7fbdf
Compare
ureeves
requested review from
miloszm,
fed-franz,
HDauven,
moCello and
herr-seppia
Changes the instance reclamation code to allow for exactly one module instance per contract function call. This changes the way in which the node processes the state, leading to diverging state roots on errorring calls. Simplifies the instance code by using a boolean to appropriately drop the instance. This allows the data in the struct to be passed around the `Env`, whilst fixing some bad dereferences previously occurring under certain situations. Resolves: #325
ureeves
force-pushed
the
single-instance-per-call
branch
from
1e7fbdf to
cfe6134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the instance reclamation code to allow for exactly one module instance per contract function call. This changes the way in which the node processes the state, leading to diverging state roots on errorring calls.
Simplifies the instance code by using a boolean to appropriately drop the instance. This allows the data in the struct to be passed around the
Env, whilst fixing some bad dereferences previously occurring under certain situations.Resolves: #325