Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate failing 'cc_passthrough' test on macos #335

Open
miloszm opened this issue Feb 15, 2024 · 1 comment
Open

Investigate failing 'cc_passthrough' test on macos #335

miloszm opened this issue Feb 15, 2024 · 1 comment
Assignees
Labels
fix:bug Something isn't working team:Core Low Level Core Development Team (Rust)

Comments

@miloszm
Copy link
Contributor

miloszm commented Feb 15, 2024

Summary

cc_passthrough test on macos gives validation error, it should pass. As a result, make test fails on macos for the current main Piecrust branch

Possible solution design or implementation

It is easy to temporarily fix the test by changing a string sent to method query_passthrough from query_value to query_va. Looks like all strings having length 8 or more, are causing the validation error, only strings up to length 7 pass. This happens only if function return value is a pair (String, Vec<u8>), if the string is returned alone, not in a pair, the problem does not occur, it also does not matter if a pair is (String, Vec<u8>) or (Vec<u8>, String).

Additional context

The problem does not occur on linux platforms.

@miloszm miloszm added the team:Core Low Level Core Development Team (Rust) label Feb 15, 2024
@ureeves ureeves added the fix:bug Something isn't working label Apr 10, 2024
@HDauven
Copy link
Member

HDauven commented Apr 10, 2024

This happens on x86 Mac, have not seen a similar situation on ARM Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix:bug Something isn't working team:Core Low Level Core Development Team (Rust)
Projects
None yet
Development

No branches or pull requests

3 participants