You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For contract compilation we use setting cranelift_nan_canonicalization which should make float-related instructions deterministic. This is done "just in case" as in general we should not allow float-related instructions in our contracts. Currently, we do not have a test that checks that we handle deployment of contracts with float-related instructions properly, i.e., we do not allow such contracts to be deployed.
Possible solution design or implementation
Add a counter contract which uses floating point number type and try to deploy it in a test. Test should make sure that such contract cannot be deployed and that deployment call fails with a proper error code.
Additional context
Note that we used to have such test in the previous VM, yet our current implementation is missing it. It needs to be re-introduced and adjusted to the current codebase.
The text was updated successfully, but these errors were encountered:
Summary
For contract compilation we use setting
cranelift_nan_canonicalization
which should make float-related instructions deterministic. This is done "just in case" as in general we should not allow float-related instructions in our contracts. Currently, we do not have a test that checks that we handle deployment of contracts with float-related instructions properly, i.e., we do not allow such contracts to be deployed.Possible solution design or implementation
Add a counter contract which uses floating point number type and try to deploy it in a test. Test should make sure that such contract cannot be deployed and that deployment call fails with a proper error code.
Additional context
Note that we used to have such test in the previous VM, yet our current implementation is missing it. It needs to be re-introduced and adjusted to the current codebase.
The text was updated successfully, but these errors were encountered: