Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store merkle positions in binary rather than using RKYV serialisation #410

Open
miloszm opened this issue Dec 2, 2024 · 0 comments
Open
Assignees

Comments

@miloszm
Copy link
Contributor

miloszm commented Dec 2, 2024

Summary

Storing as RKYV serialisation does not scale well for large files, as it requires extra cloning.
It will be more efficient to use binary representation.
Also, some optimisations can be made like storing merkle contract id as u32 rather than u64 as its upper 32 bits are always zero.

Possible solution design or implementation

Implement both and compare results. If time savings are substantial, switch to the new method.
Maintain the old method for backwards compatibility, so if the new file does not exist, use the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant