Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phoenix and Moonlight transactions should have different JSON representations #1991

Open
ureeves opened this issue Jul 22, 2024 · 0 comments
Open

Phoenix and Moonlight transactions should have different JSON representations #1991

ureeves opened this issue Jul 22, 2024 · 0 comments

Comments

@ureeves
Copy link
Member

ureeves commented Jul 22, 2024

Phoenix and Moonlight transaction should have different JSON representations to make them easier to differentiate downstream. This would make for an easier viewing, and perhaps querying experience.

PhoenixTx and MoonlightTx should have a different json repr (to avoid all of this "if let" and removing unused fields (like nullifiers for MoonlightTx)

Originally posted by @herr-seppia in #1930 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ureeves