Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stake events should emit JSON #2266

Closed
autholykos opened this issue Sep 4, 2024 · 4 comments
Closed

Stake events should emit JSON #2266

autholykos opened this issue Sep 4, 2024 · 4 comments
Assignees

Comments

@autholykos
Copy link
Member

This item pertains to "implement stake events changes". To be discussed with @herr-seppia

@autholykos
Copy link
Member Author

There is a dependency on what Piecrust can do

@herr-seppia
Copy link
Member

There is a dependency on what Piecrust can do

Piecrust features shipped and imported into rusk

@herr-seppia herr-seppia self-assigned this Sep 5, 2024
@herr-seppia
Copy link
Member

I don't know it this worth.
Emitting events in JSON add a bit overhead (and code complexity) for json serialization and deserialization.

Furthermore, if we are going to connect consensus to stake events we'are going to introduce deserialization costs (current rkyv events are already deserialized)

@herr-seppia
Copy link
Member

Closing, as the rkyv/json should be implemented by the archiver (if needed)

@herr-seppia herr-seppia closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants