Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove placeholders that have been removed from paramstore #466

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Nov 22, 2024

Description

Remove placeholders for parameters which no longer exist in AWS Param store.

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

…lowup ticket will assess if config blocks can go too
@fibble fibble requested review from ilindsay and a team as code owners November 22, 2024 17:09
@sdh100shaun sdh100shaun merged commit 41f8333 into main Nov 25, 2024
21 checks passed
@sdh100shaun sdh100shaun deleted the remove-deprecated-placeholders-from-config-fix-parambag-errors branch November 25, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants