Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve album/playlist view song highlight #498

Open
rpgdev opened this issue Oct 24, 2024 · 8 comments
Open

Improve album/playlist view song highlight #498

rpgdev opened this issue Oct 24, 2024 · 8 comments

Comments

@rpgdev
Copy link

rpgdev commented Oct 24, 2024

Right now, if you select a song to play it remains highlighted even after you move the mouse away from it or the next song starts to play. This is confusing because when you go to heart or rate the currently playing song it seems like that's the one playing when it may not be. I believe the persistent, row highlight should track the currently playing song for improved usability.

@dweymouth
Copy link
Owner

It remains highlighted because it's still selected. If you click somewhere else off of the tracklist you deselect it and nothing would be highlighted anymore. Are you suggesting a setting where whenever a new track begins playing, it is automatically selected if it is in the current view? (e.g. "selection follows playback")

@rpgdev
Copy link
Author

rpgdev commented Oct 31, 2024

I understand why it happens but leaving selected a song that stops being relevant once the next song starts playing it's confusing when you go to the far right of the screen to either rate or heart a song (the fact that the hover highlight disappears once you put the cursor on the heart or stars doesn't help either, but that's a different issue). You can take spotify as a guide to see how they avoid this confusion (they disappear the selection, though only bold the song title avoiding confusing the user). My suggestion is to move the selection highlight to the currently playing song once it changes or just follow what spotify does.

@kernal64
Copy link

There should be a triangle in front of the currently playing song. So if you like it, press the heart in that row. For me there is no confusion about it.

@rpgdev
Copy link
Author

rpgdev commented Oct 31, 2024

The triangle indicating the currently playing song is positioned on the far left, but once the next song starts, there’s no clear highlight visible on the right side to show what’s playing now. This is confusing, as the initially selected song remains highlighted even after it’s no longer playing, which isn't intuitive. I think Spotify’s approach makes more sense here. Alternatively, adding options to heart and rate in the "Now Playing" widget at the bottom of the screen could also work. It wouldn’t address this issue, but it would make it less noticeable since users would have a more convenient way to rate and heart the currently playing track.

@dweymouth
Copy link
Owner

Alternatively, adding options to heart and rate in the "Now Playing" widget at the bottom of the screen could also work.

This is accessible from the "three dots" menu button next to the track title in the bottom display

@rpgdev
Copy link
Author

rpgdev commented Oct 31, 2024

@dweymouth I know, an additional click compared to doing it on the playlist.

@UltraBlackLinux
Copy link

UltraBlackLinux commented Nov 11, 2024

It remains highlighted because it's still selected. If you click somewhere else off of the tracklist you deselect it and nothing would be highlighted anymore.

Hm I find this to be a bit confusing. I just had my own struggles with the highlighting. After ctrl + a I couldn't deselect any tracks because I tried to click on other tracks. After following your suggestion and clicking on the black bar at the top (the bar with the media controls or the tab switcher buttons do not work - As a matter of fact, I think only switching tabs and clicking the black bar at the top works, no other space wants to deselect the tracks) I was able to deselect the tracks.

This just cost me all my favorites but I was able to restore them from my play queue :)

@dweymouth
Copy link
Owner

@UltraBlackLinux this commit 1d342bf should resolve the issue of being unable to unselect tracks by clicking on the background. Will be in the next bugfix release coming soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants