You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
They compare the value to the special 0x40 epsilon value and the ID constants. Unless I'm missing something, these will return the wrong result for modules with more than 64 types (which seems not to be covered by the specification testsuite). I believe this needs to be handled in the parser when decoding the binary type ID values.
The text was updated successfully, but these errors were encountered:
I think that the implementation is following the spec in this case, in this regard, please note that 0x40 is not an upper bound, but a "reserved value".
Have you found any error?
Would you be able to provide a reproducer?
The following methods evaluate type IDs:
com.dylibso.chicory.runtime.TypeValidator#getReturns
com.dylibso.chicory.runtime.InterpreterMachine#numberOfValuesToReturn
com.dylibso.chicory.aot.AotMachine#blockType
They compare the value to the special
0x40
epsilon value and the ID constants. Unless I'm missing something, these will return the wrong result for modules with more than 64 types (which seems not to be covered by the specification testsuite). I believe this needs to be handled in the parser when decoding the binary type ID values.The text was updated successfully, but these errors were encountered: