-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory
: improve error handling for "out of bounds memory access"
#603
Comments
While I generally agree about not creating exceptions needlessly, does it actually matter here? When OOB access occurs, the WASM program is terminated. I just noticed that |
I've spent the last few hours tracking down a crash due to this exception, and having context (index, bounds, stack trace) might have made this easier. Also, just as a social/psychological thing: Seeing the plain "out of bounds memory access" exception with no information made me think that no one was using Chicory, because if anyone did, they'd have fixed this exception to include useful information. (I might be wrong about this, I'm just reporting how the exception made me see the project.) |
Hi @lkesteloot and thanks a lot for your interest in the project! For context, most of the "text" part of the exceptions is driven by the expectations in the Wasm Testsuite. That said, I agree that this is a rough edge and we should improve. |
IndexOutOfBoundsException
, even when we are already aware of the limits; we should be able to check those limits explicitly, avoiding an expensive exception to be createdThe text was updated successfully, but these errors were encountered: