Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix proto update opt in status response #1642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix proto update opt in status response #1642

wants to merge 1 commit into from

Conversation

DSHIVAAY-23
Copy link

closes #1627

@DSHIVAAY-23 DSHIVAAY-23 requested a review from a team as a code owner December 10, 2024 18:29
@mtsitrin
Copy link
Contributor

@DSHIVAAY-23 you should run make proto-gen after the update and update the .go files

@DSHIVAAY-23
Copy link
Author

@DSHIVAAY-23 you should run make proto-gen after the update and update the .go files

should i make a new commit or just ammend on it?

@DSHIVAAY-23 DSHIVAAY-23 reopened this Dec 11, 2024
@DSHIVAAY-23 DSHIVAAY-23 force-pushed the divyank/update_msg_response branch from d7f7068 to c8a1d6e Compare December 11, 2024 18:32
@mtsitrin
Copy link
Contributor

@DSHIVAAY-23 pls generate the .go file (make proto-gen) in new commit

@DSHIVAAY-23
Copy link
Author

make proto-gen

cp: can't stat 'github.com/dymensionxyz/dymension/v*/*': No such file or directory
make: *** [Makefile:178: proto-gen] Error 1
getting this error while running this command

@danwt
Copy link
Contributor

danwt commented Dec 19, 2024

Might need to pull dependencies first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/sequencer proto update opt in status, need to use response
3 participants
@DSHIVAAY-23 @mtsitrin @danwt