Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide if we should allow "that" in "Given I" such as "Given that I" #46

Open
densizengin opened this issue Nov 16, 2023 · 2 comments
Open
Assignees

Comments

@densizengin
Copy link
Member

pkg/core/src/parser.ts:66

What should be the outcome if "that" isn't provided? Should the parser just consume "that" when it is in there and fallback to not using "that"? I think this sounds reasonable.

@densizengin densizengin self-assigned this Nov 18, 2023
@densizengin
Copy link
Member Author

@puria, @andrea-dintino, @jaromil, please comment on this.

@jaromil
Copy link
Member

jaromil commented Nov 18, 2023

@srfsh the word "that" is not tolerated in zencode. the pronoun "I" is tolerated and fully optional. For more info on the tolerated nop words see https://github.com/dyne/Zenroom/blob/7907284d544534da233098bd44ed6f92bfd99046/src/lua/zencode.lua#L151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants