Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS certificates are not checked #6

Open
davidn opened this issue Aug 1, 2013 · 2 comments
Open

HTTPS certificates are not checked #6

davidn opened this issue Aug 1, 2013 · 2 comments

Comments

@davidn
Copy link

davidn commented Aug 1, 2013

The library uses python's httplib.HTTPSConnection to connect to the Dyn API endpoint. The python documentation notes "Warning: This does not do any verification of the server’s certificate."

Without certificate verification, if an attacker is able to intercept the traffic she can read or even alter the communications.

It does not seem that httplib provides a way to do this verification. Some people have produced a HTTPSConnection wrapper to do validation. Other people recommend using pycurl.

@medina
Copy link

medina commented Feb 4, 2014

How about using requests instead?

Yes, another dependency, but it solves a number of issues including this one.

@egon1024
Copy link
Contributor

egon1024 commented Feb 4, 2014

It's a good question. We tried very hard not to require any external libraries for this package. We might have to give in on that idea though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants