Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.php: PHP 8.2 exception handler signature compatibility #5073

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Deltik
Copy link
Member

@Deltik Deltik commented Sep 11, 2023

Motivation and Context

Fixes: #5072

Description

The exception handler parameter has to be of type Throwable, but we are remaining compatible with PHP 5.6, which didn't have Throwable, so let's fix this by moving the type to the phpDoc block.

How Has This Been Tested?

Human static code analysis?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

The exception handler parameter has to be of type `Throwable`, but we
are remaining compatible with PHP 5.6, which didn't have `Throwable`,
so let's fix this by moving the type to the phpDoc block.

Fixes: e107inc#5072
@codeclimate
Copy link

codeclimate bot commented Sep 11, 2023

Code Climate has analyzed commit c6401ff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 34.7% (0.1% change).

View more on Code Climate.

@CaMer0n CaMer0n merged commit 7394a6c into e107inc:master Sep 12, 2023
99 checks passed
@Deltik Deltik deleted the fix/5072 branch September 12, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix normally not visible fatal error
2 participants