Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation: Produce Delete Events from GreenInterpreter? #368

Open
anthonyanjorin opened this issue Sep 2, 2018 · 2 comments
Open

Optimisation: Produce Delete Events from GreenInterpreter? #368

anthonyanjorin opened this issue Sep 2, 2018 · 2 comments
Assignees

Comments

@anthonyanjorin
Copy link
Contributor

The green interpreter knows in some cases that a certain match is now invalid. It could produce a delete event in such cases so that the operation is informed and can directly invalidate the match.

@Arikae
Copy link
Collaborator

Arikae commented Dec 3, 2018

Not sure about this.
Does this means that the event is directly delegated to the green interpreter?
Wouldn't that bypass the whole repair process?

@anthonyanjorin
Copy link
Contributor Author

If the green interpreter gets a match m that creates an edge between two objects, then it knows already that this match is invalid and can be discarded (no double edges in emf). The green interpreter could therefore invalidate the match directly.

At the moment we don’t do this: we forget the match is invalid and do nothing. Later on the match could be tried again, will be inspected and identified as invalid and then removed. I’m not sure how inefficient this is - but it is certainly redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants