Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If forum is a category, do not look for topics #15

Open
ePascalC opened this issue Jul 10, 2017 · 7 comments
Open

If forum is a category, do not look for topics #15

ePascalC opened this issue Jul 10, 2017 · 7 comments

Comments

@ePascalC
Copy link
Owner

No description provided.

@ntwb
Copy link

ntwb commented Jul 11, 2017

FYI: A category forum can contain topics

Typically they don't, but there are various methods of achieving this, one such way is to create a topic in the forum before changing the forum to a category

@ePascalC
Copy link
Owner Author

Fully agree, I have converted a forum to a category and back to forum and of course still had the topics. But if in the API the details of a category are requested, should the attached topics be shown?

@ntwb
Copy link

ntwb commented Jul 11, 2017

I think they should, the use case I've typically seen for this is a "placeholder" topic in the category forum, typically this topic is closed to new replies and contains a FAQ of sorts to the forums contained within the category

@ePascalC
Copy link
Owner Author

Great reasoning, so also categories should show the topics. But so this means also the 'post new topic' should allow posting to a category.

@tkserver
Copy link

I don't disagree with the logic of the discussion, however I will not be allowing my app users on my own site to post in a category. If I wanted them to be able to do that I would have made it a forum!

@ntwb
Copy link

ntwb commented Jul 11, 2017

This should follow bbPress' standard permissions, standard users aka participants can not post new topics in a category, buy keymasters can

It's 2am here, I'm not checking the code for what permissions moderators have in this regard, but the same deal, whatever permissions moderators have should also be used 😏

@ePascalC
Copy link
Owner Author

On that part I see no issue. All permissions apply as standard bbp_insert_post is used. I'm still only doing anonymous inserting (well, with a small twist for now), but when 'logged in', the POST will fail if the poster has no adequate permissions.
Get some sleep ! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants