Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++/Fotran examples on RTD use outdated BMI #140

Open
Peter9192 opened this issue Aug 31, 2023 · 1 comment
Open

C++/Fotran examples on RTD use outdated BMI #140

Peter9192 opened this issue Aug 31, 2023 · 1 comment

Comments

@Peter9192
Copy link
Contributor

The instructions on adding a BMI server for c++/fortran models uses quite old BMI definitions, which make it confusing.

https://github.com/eWaterCycle/grpc4bmi/blob/main/docs/server/Cpp.rst

For example:

  • Latest bmi c++ uses Pascal Case for method names
  • Latest bmi c++ uses std:string instead of char*
  • Latest bmi fortran uses bmif_get_conmponent_name instead of get_component_name_f
  • Latest bmi c++ heat example uses extensions .cxx and .hxx. It would be nice to be consistent with the heat example.
@Peter9192
Copy link
Contributor Author

Might also want to change the g++ command to a cmake command as that's what's used now in all bmi examples and also in the heat examples shipped with grpc4bmi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant