feat: implement MCP23017 I/O Expander driver #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the driver for the MCP23017 device. The code is missing comments and documentation. The code compiles but it has not been tested yet. BREAKING CHANGE: None
BREAKING CHANGE: None
gmazzucchi
requested changes
Nov 18, 2023
There was a problem hiding this comment.
Ok, just very verbose. The less and simpler you write the better. Please try to shorten the code and make it simpler (less typedef, ...). The .h is good, I like it, please review the .c, 600 lines of code are really too much for that job. Need to change a couple of things for the style and then proceed to the testing phase.
gmazzucchi
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the driver for the MCP23017 device.
The code is missing comments and documentation.
The code compiles but it has not been tested yet.
BREAKING CHANGE: None