Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert DOS line breaks to Unix #85

Open
qdread opened this issue Jan 22, 2024 · 1 comment
Open

Convert DOS line breaks to Unix #85

qdread opened this issue Jan 22, 2024 · 1 comment

Comments

@qdread
Copy link
Contributor

qdread commented Jan 22, 2024

In #84 a user creates his job locally on a Windows machine then copies the scripts to HPC and submits the job there. I think this is a common enough workflow. It raises the issue that if you do this, the .sh scripts will not have Unix line breaks and can't be executed. It might be good to modify slurm_apply and related functions to run something like sed -i.bak "s/\r$//" submit.sh?

@mhesselbarth
Copy link

A quick follow up on this. I just saw that the slurm_run.R script has the same DOS line breaks. It doesn't seem to be am obvious problem, but might cause issues down the line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants