Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagbot labels with 'update' if I contribute two versions of the same software (even if that software is new in EasyBuild) #21816

Open
casparvl opened this issue Nov 11, 2024 · 0 comments

Comments

@casparvl
Copy link
Contributor

To be precise, I had:

  • A PR that added one version (AladinDesktop-12.060-Java-17.eb)
  • Then, I added another (AladinDesktop-12.060-GCCcore-13.2.0-Java-17.eb). The tag bot now automatically labeled with 'update', I guess because it found the previous commit in this same branch, and consider this an 'update' of that.
  • Then, I removed (AladinDesktop-12.060-Java-17.eb) and the tagbot correctly labeled the PR as 'new' again.

Now, I guess this is a bit of a corner case, and I'm not sure if it is even a bug. That depends on what the design goal of the tag was, but I assume it is to check if it is new in the EasyBuild main/develop branches, not in my feature branch... I.e. I'm not sure if this is possible, but I guess it should check for prior existence in main/develop, and not the current (i.e. feature) branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant