Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palette_colorhex() requires R 4.1 to work #274

Merged
merged 3 commits into from
Mar 18, 2023
Merged

palette_colorhex() requires R 4.1 to work #274

merged 3 commits into from
Mar 18, 2023

Conversation

strengejacke
Copy link
Member

Fixes #273

@strengejacke
Copy link
Member Author 

see::palette_colorhex(30415) # cool blue
#> function (n) 
#> {
#>     x <- ramp(seq.int(0, 1, length.out = n))
#>     if (ncol(x) == 4L) 
#>         rgb(x[, 1L], x[, 2L], x[, 3L], x[, 4L], maxColorValue = 255)
#>     else rgb(x[, 1L], x[, 2L], x[, 3L], maxColorValue = 255)
#> }
#> <bytecode: 0x000001f69d7b2798>
#> <environment: 0x000001f69d7c55f0>
#> attr(,"name")
#> [1] "cool blue"
see::palette_colorhex(1023536) # QUICK CREDIT PRO
#> function (n) 
#> {
#>     x <- ramp(seq.int(0, 1, length.out = n))
#>     if (ncol(x) == 4L) 
#>         rgb(x[, 1L], x[, 2L], x[, 3L], x[, 4L], maxColorValue = 255)
#>     else rgb(x[, 1L], x[, 2L], x[, 3L], maxColorValue = 255)
#> }
#> <bytecode: 0x000001f69d7b2798>
#> <environment: 0x000001f69d87d880>
#> attr(,"name")
#> [1] "QUICK CREDIT PRO"

Created on 2023-03-18 with reprex v2.0.2

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@fe7cbdb). Click here to learn what that means.
The diff coverage is 0.00%.

❗ Current head 548d0f2 differs from pull request most recent head aca6ebf. Consider uploading reports for the commit aca6ebf to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage        ?   44.49%           
=======================================
  Files           ?       65           
  Lines           ?     4477           
  Branches        ?        0           
=======================================
  Hits            ?     1992           
  Misses          ?     2485           
  Partials        ?        0
Impacted Files Coverage Δ
R/scale_color_colorhex.R 45.90% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil IndrajeetPatil requested a review from bwiernik March 18, 2023 14:59
@IndrajeetPatil
Copy link
Member

Thanks for the quick fix, @strengejacke!

Let's check with @bwiernik if all is well; he had added this function to {see}.

@bwiernik
Copy link
Contributor

Looks good to me

@IndrajeetPatil IndrajeetPatil merged commit 1abb493 into main Mar 18, 2023
@IndrajeetPatil IndrajeetPatil deleted the strengejacke/issue273 branch March 18, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwiernik bwiernik bwiernik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

palette_colorhex() requires R 4.1 to work
4 participants
@strengejacke @codecov-commenter @IndrajeetPatil @bwiernik