From 58c5daeb2ad9762a52f47150dc298a7c14044f3e Mon Sep 17 00:00:00 2001 From: Daniel Date: Tue, 16 Jul 2024 22:17:52 +0200 Subject: [PATCH 1/3] Check test failures on oldrel-Windows Fixes #348 --- NAMESPACE | 4 ++-- R/plot.dw_data_tabulate.R | 12 ++++++------ ....dw_data_tabulate.Rd => plot.datawizard_table.Rd} | 10 +++++----- tests/testthat/test-plot.dw_data_tabulate.R | 4 ++-- 4 files changed, 15 insertions(+), 15 deletions(-) rename man/{plot.dw_data_tabulate.Rd => plot.datawizard_table.Rd} (91%) diff --git a/NAMESPACE b/NAMESPACE index 4efe799b3..7dcf77601 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -23,8 +23,8 @@ S3method(data_plot,performance_pp_check) S3method(data_plot,point_estimate) S3method(data_plot,rope) S3method(data_plot,see_compare_parameters) -S3method(plot,dw_data_tabulate) -S3method(plot,dw_data_tabulates) +S3method(plot,datawizard_table) +S3method(plot,datawizard_tables) S3method(plot,see_bayesfactor_models) S3method(plot,see_bayesfactor_parameters) S3method(plot,see_bayesfactor_savagedickey) diff --git a/R/plot.dw_data_tabulate.R b/R/plot.dw_data_tabulate.R index 93b18770c..768e69de5 100644 --- a/R/plot.dw_data_tabulate.R +++ b/R/plot.dw_data_tabulate.R @@ -21,10 +21,10 @@ #' Interval estimation for a binomial proportion. #' _Statistical Science_, _16_(2), 101-133. \doi{10.1214/ss/1009213286} #' -#' @rdname plot.dw_data_tabulate +#' @rdname plot.datawizard_table #' @export -plot.dw_data_tabulates <- function(x, label_values = TRUE, +plot.datawizard_tables <- function(x, label_values = TRUE, show_na = c("if_any", "always", "never"), na_label = "(Missing)", error_bar = TRUE, @@ -34,7 +34,7 @@ plot.dw_data_tabulates <- function(x, label_values = TRUE, ...) { show_na <- match.arg(show_na, choices = c("if_any", "always", "never")) if (length(x) == 1L) { - plot.dw_data_tabulate( + plot.datawizard_table( x[[1]], label_values = label_values, show_na = show_na, @@ -47,7 +47,7 @@ plot.dw_data_tabulates <- function(x, label_values = TRUE, } else { lapply( x, - plot.dw_data_tabulate, + plot.datawizard_table, label_values = label_values, show_na = show_na, na_label = na_label, @@ -59,11 +59,11 @@ plot.dw_data_tabulates <- function(x, label_values = TRUE, } } -#' @rdname plot.dw_data_tabulate +#' @rdname plot.datawizard_table #' #' @export -plot.dw_data_tabulate <- function(x, label_values = TRUE, +plot.datawizard_table <- function(x, label_values = TRUE, show_na = c("if_any", "always", "never"), na_label = "(Missing)", error_bar = TRUE, diff --git a/man/plot.dw_data_tabulate.Rd b/man/plot.datawizard_table.Rd similarity index 91% rename from man/plot.dw_data_tabulate.Rd rename to man/plot.datawizard_table.Rd index 0e5d06e1b..23d978982 100644 --- a/man/plot.dw_data_tabulate.Rd +++ b/man/plot.datawizard_table.Rd @@ -1,11 +1,11 @@ % Generated by roxygen2: do not edit by hand % Please edit documentation in R/plot.dw_data_tabulate.R -\name{plot.dw_data_tabulates} -\alias{plot.dw_data_tabulates} -\alias{plot.dw_data_tabulate} +\name{plot.datawizard_tables} +\alias{plot.datawizard_tables} +\alias{plot.datawizard_table} \title{Plot tabulated data.} \usage{ -\method{plot}{dw_data_tabulates}( +\method{plot}{datawizard_tables}( x, label_values = TRUE, show_na = c("if_any", "always", "never"), @@ -17,7 +17,7 @@ ... ) -\method{plot}{dw_data_tabulate}( +\method{plot}{datawizard_table}( x, label_values = TRUE, show_na = c("if_any", "always", "never"), diff --git a/tests/testthat/test-plot.dw_data_tabulate.R b/tests/testthat/test-plot.dw_data_tabulate.R index 40dd660a7..77cbb0280 100644 --- a/tests/testthat/test-plot.dw_data_tabulate.R +++ b/tests/testthat/test-plot.dw_data_tabulate.R @@ -1,9 +1,9 @@ -test_that("`plot.dw_data_tabulate()` works with single table", { +test_that("`plot.datawizard_table()` works with single table", { x <- datawizard::data_tabulate(mtcars, select = "cyl") expect_s3_class(plot(x), "gg") }) -test_that("`plot.dw_data_tabulate()` works with multiple tables", { +test_that("`plot.datawizard_table()` works with multiple tables", { x <- datawizard::data_tabulate(mtcars, select = c("cyl", "carb", "am")) expect_true(is.list(plot(x))) }) From d4a220f802014a1560e8ada369fbd650454f701e Mon Sep 17 00:00:00 2001 From: Daniel Date: Tue, 16 Jul 2024 22:18:46 +0200 Subject: [PATCH 2/3] desc, news --- DESCRIPTION | 6 +++--- NEWS.md | 5 ++++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 4b5efbef4..ba3c556b4 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Type: Package Package: see Title: Model Visualisation Toolbox for 'easystats' and 'ggplot2' -Version: 0.8.4.7 -Authors@R: +Version: 0.8.4.8 +Authors@R: c(person(given = "Daniel", family = "Lüdecke", role = c("aut", "ctb"), @@ -52,7 +52,7 @@ Maintainer: Indrajeet Patil Description: Provides plotting utilities supporting packages in the 'easystats' ecosystem () and some extra themes, geoms, and scales for 'ggplot2'. Color scales are based on - . + . References: Lüdecke et al. (2021) . License: MIT + file LICENSE URL: https://easystats.github.io/see/ diff --git a/NEWS.md b/NEWS.md index cfc5d3202..c95c6c0f6 100644 --- a/NEWS.md +++ b/NEWS.md @@ -11,6 +11,10 @@ * Gets rid of warnings due to API changes in the `{datawizard}` package. +## Bug fixes + +* Fixed CRAN test failures on oldrel-Windows. + # see 0.8.4 ## Minor Changes @@ -626,4 +630,3 @@ ## Bug fixes * Fixed issues with color codes in the flat-ui palette. - From 4743ea7915b9c71d32a3d8836075fc91c3cc8c9a Mon Sep 17 00:00:00 2001 From: Daniel Date: Tue, 16 Jul 2024 22:45:42 +0200 Subject: [PATCH 3/3] spell --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index c95c6c0f6..912655e26 100644 --- a/NEWS.md +++ b/NEWS.md @@ -13,7 +13,7 @@ ## Bug fixes -* Fixed CRAN test failures on oldrel-Windows. +* Fixed CRAN test failures. # see 0.8.4