-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revdepcheck
action doesn't work?
#33
Comments
I think easystats/performance#556 can be a good testing ground for this. Right now, if we run revdepcheck on parameters, performance breakage should show up. |
All revdep checks pass: https://github.com/easystats/parameters/actions/runs/4494885631/jobs/7907926195?pr=859 Looks like there's sth wrong here |
Yeah, but it's not clear to me if the tests are comparable across CRAN and GitHub versions of performance in terms of their reliance on parameters. I am going to make an extremely breaking change (like removing an export) and then check again. If that doesn't break anything then, yes, this workflow is not working as expected. |
Yeah, definitely this workflow is not working. I don't understand why, though. It's the same code one runs locally. |
@easystats/maintainers Just FYI: in case you are thinking of using the revdepcheck, that workflow is currently not working. You will need to either run it locally yourself or wait for CRAN to run it after submission. |
Thanks, I usually also run local revdep checks |
Cf easystats/datawizard#385
The text was updated successfully, but these errors were encountered: