Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded to pandas 2.1 #170

Merged
merged 1 commit into from
Nov 7, 2023
Merged

upgraded to pandas 2.1 #170

merged 1 commit into from
Nov 7, 2023

Conversation

tomsail
Copy link
Collaborator

@tomsail tomsail commented Nov 6, 2023

make test_full
succeeded (excepted mayavi)

@tomsail tomsail requested a review from pmav99 November 6, 2023 12:18
@tomsail tomsail added the enhancement New feature or request label Nov 6, 2023
@tomsail tomsail mentioned this pull request Nov 6, 2023
@tomsail
Copy link
Collaborator Author

tomsail commented Nov 6, 2023

Ok I might have problems to reproduce the fail here: I am trying to build as in the CI:

mamba create  --name pyposeidon --file locks/conda-ubuntu-latest-binary-p3.9.lock 
mamba activate schism
mamba activate --stack pyposeidon
python -mpip install -r "${REQUIREMENTS_CI}"
python -mpip install ./

last line actially updates pandas :

Successfully built pyposeidon
Installing collected packages: tzdata, pandas, pyposeidon
  Attempting uninstall: pandas
    Found existing installation: pandas 1.5.3
    Uninstalling pandas-1.5.3:
      Successfully uninstalled pandas-1.5.3
Successfully installed pandas-2.1.2 pyposeidon-0.6.0 tzdata-2023.3

make test_schism passes for all 3 versions of python.

@tomsail
Copy link
Collaborator Author

tomsail commented Nov 6, 2023

sorry for the confusion. It was hard to debug and isolate the error. I have kept the changes minimal. PR ready to merge when GitHub CI will be finished.

@pmav99
Copy link
Collaborator

pmav99 commented Nov 6, 2023

  1. Please rebase and fixup the commits into a single one with an appropriate commit message (e.g. "Add pandas 2 compatibility" or something similar)
  2. if not too much trouble please test if this works with 1.X, too. I think It should. Just test it locally and if it is ok, then just remove the constraint from pandas - i.e. use pandas = "*"

Other than that, good work!

@tomsail
Copy link
Collaborator Author

tomsail commented Nov 6, 2023

Thanks @pmav99. Yes tried already the option on my laptop. It should work

@tomsail tomsail merged commit 9cfd3bb into ec-jrc:master Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants