Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rust perspective #181

Closed
mickaelistria opened this issue Nov 30, 2018 · 16 comments
Closed

Remove Rust perspective #181

mickaelistria opened this issue Nov 30, 2018 · 16 comments

Comments

@mickaelistria
Copy link
Contributor

The Rust perspective seems to bring nothing over default Resources and Debug ones. It would probably be better to remove it if it doesn't add value.

@akurtakov
Copy link
Member

Fully agreed. @norru @Boereck wdyt?

@serjiokov
Copy link

Hello, I think specific perspective may exist for Rust Development in further it will aggregate some rust specific viewers.
I've prepared fix to switch Rust Perspective from New Project Wizard.

@mickaelistria
Copy link
Contributor Author

I think as long as there are no specific view, we should bother with the perspective.
Extra views could also be added by default as perspective extensions on the resource views if necessary.
If we need to re-implement a perspective later, it's all fine. It will be even better as we'll have a use-case for it to drive to a better implementation, while we currently have no reason for it.

I've prepared fix to switch Rust Perspective from New Project Wizard.

What's the added value over current state?

@serjiokov
Copy link

What's the added value over current state?

I mean prepared on the local branch:

  • in plugin.xml : preferredPerspectives="org.eclipse.corrosion.rustPerspective"
  • in NewCargoProjectWizard: usage of BasicNewProjectResourceWizard.updatePerspective(configuration);

@serjiokov
Copy link

As I see the fix not needed. Right?

@mickaelistria
Copy link
Contributor Author

At the moment, I think it's better for end-users and maintainers to remove the perspective and stick to the Resource one; unless we have a compelling use-case for it.
That doesn't prevent from re-introducing a perspective later when we think there is enough value to justify it, but at the moment, this doesn't seem to be the case.

@serjiokov
Copy link

Ok, we can define defualt or prefered perspective like Resouces or C++ or you other, (could you suggest?) and swirch to it.

@norru
Copy link
Contributor

norru commented Jan 15, 2019

@serjiokov I would not like C++ as it would be misleading. Would prefer Resource..

@serjiokov
Copy link

Resource perspective quite simple without launch toolbar. It is not friendly to me. Any ideas?

@serjiokov
Copy link

ice_screenshot_20190116-164549

serjiokov pushed a commit to serjiokov/corrosion that referenced this issue Jan 16, 2019
see bug eclipse-corrosion#181

Removed perspective definition
Provided perspective switching to finalPerspective
Disable TestPespective

Signed-off-by: Sergei Kovalchuk <[email protected]>
serjiokov pushed a commit to serjiokov/corrosion that referenced this issue Jan 16, 2019
see bug eclipse-corrosion#181

Corrected LNE

Signed-off-by: Sergei Kovalchuk <[email protected]>
@norru
Copy link
Contributor

norru commented Jan 16, 2019

I'm not familiar with this. Is it not possible to pre-add the launch toolbar to the existing perspective?

@norru
Copy link
Contributor

norru commented Jan 17, 2019

@mickaelistria @serjiokov I have been mulling over this for a bit. I am no longer sure removing the perspective is a good idea

The problem here is that users would expect something to contain the Rust environment, and that something for Eclipse users is possibly expected to be a pre-defined "custom" perspective. In fact, I find it handy and reassuring to have the little "R" logo on the top right just to switch back to Rust coding after say, moving to the Debug perspective or to some other ones I may have around (ie in my case GLSL tools)

selection_124

There is some sort of "branding" power we'd lose if we removed it.

Perhaps we should reconsider?

@mickaelistria
Copy link
Contributor Author

There is some sort of "branding" power we'd lose if we removed it.

Do we (developers) and users need this power right now? Maintaining such power has a cost for us (which in that case I'm not likely to pay); it also has a cost for users because of multiplication of perspectives which some users hate.
In my experience, and I did work a lot on branded plugins in the IDE with JBoss Tools, users actually prefer simplicity over branding which is perceived as noise unless it provides them added-value, ie make them often more productive.

@norru
Copy link
Contributor

norru commented Jan 17, 2019

(which in that case I'm not likely to pay)

Fair enough, scarce resource means prioritization. However, we may have revisit the perspective implementation in a few months and see if there is any feedback on the lack of a "dedicated" space.

@mickaelistria
Copy link
Contributor Author

I've opened #219 and #220 to cover sub-parts of the discussion. Let's try to keep things separated for easier tracking and progress.

mickaelistria added a commit that referenced this issue Jan 24, 2019
Signed-off-by: Mickael Istria <[email protected]>
mickaelistria added a commit that referenced this issue Jan 24, 2019
@mickaelistria
Copy link
Contributor Author

Done a few months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants