-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SecurityManager references from logging package #16 #117
Conversation
Signed-off-by: jmehrens <[email protected]>
Signed-off-by: jmehrens <[email protected]>
Signed-off-by: jmehrens <[email protected]>
Summary of changes:
|
Signed-off-by: jmehrens <[email protected]>
Signed-off-by: jmehrens <[email protected]>
Signed-off-by: jmehrens <[email protected]>
Signed-off-by: jmehrens <[email protected]>
Signed-off-by: jmehrens <[email protected]>
Summary of build using /usr/lib/jvm/jdk-21-oracle-x64 to show that changes work: Reactor Summary for Angus Mail Project 2.0.3-SNAPSHOT: Angus Mail Project ................................. SUCCESS [ 45.369 s] BUILD SUCCESS Total time: 07:13 min |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- MailHandler is missing cp year update
- I prefer
Objects.requireNonNull
overif (x == null) throw new NPE
(in LogManagerProperties) but that is a matter of taste
Signed-off-by: jmehrens <[email protected]>
Signed-off-by: jmehrens <[email protected]>
Fixed copywrite year. I updated the code to use requireNonNull. There is one case that is omitted because the argument is a Throwable which interestingly enough will trigger an IDE warning that return type of Throwable was not read. That method will be dealt with in a follow on ticket. |
thanks! |
Signed-off-by: jmehrens [email protected]