FileInfoReader deadlock

[jukzi]

          Maybe an infinite loop waiting for org.eclipse.equinox.internal.p2.transport.ecf.FileInfoReader.barrier

waitOnSelf() does not synchronize the read on that while org.eclipse.equinox.internal.p2.transport.ecf.FileInfoReader.handleRemoteFileEvent(IRemoteFileSystemEvent) does synchronize for write

Originally posted by @jukzi in eclipse-pde/eclipse.pde#1481 (comment)

original reports:
eclipse-pde/eclipse.pde#1481
eclipse-pde/eclipse.pde#1160

[laeubi]

This code looks a bit suspicious on the other hand its there since 16 years now, so there are likely better ways today to solve this.

One part is also this one

p2/bundles/org.eclipse.equinox.p2.transport.ecf/src/org/eclipse/equinox/internal/p2/transport/ecf/FileInfoReader.java

Line 150 in 65348d6

barrier.notify();

it only notifies one thread, not all threads waiting... beside that it seem to be blocked in job.join() so has no chance to check the condition anyways...

[jukzi]

happens again - eclipse does not finish to start after update:

i sampled a bit:

[laeubi]

Thread State / Dump would be more interesting than CPU sampling. e.g. why does PDE hinders the IDE to start at all?

[jukzi]

Thread State / Dump would be more interesting than CPU sampling. e.g. why does PDE hinders the IDE to start at all?

see eclipse-pde/eclipse.pde#1481 (comment)

[laeubi]

From that stacktrace it seem to hang in a Java Editor that triggers init of classpath while showing a view (what triggers PDE to do something).

Still I'm wondering why all this happens before the UI is displayed....