Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline View subclasses are fully expanded by default whenever a class is selected, whereas before the Outline View was not fully expanded by default #1480

Open
jmohrmann opened this issue Jun 26, 2024 · 5 comments

Comments

@jmohrmann
Copy link

In Eclipse 2024-06, I noticed that, when selecting a Java class, the Outline View loads all the methods, subclasses, etc. for that class, but the subclasses and inner anonymous classes are all fully expanded by default.

In previous versions of Eclipse (2024-03 and prior), only methods that contained anonymous classes were expanded, not all the methods of every subclass. In 2024-06, I usually have to click "Collapse All" and then expand just the top-level type to get a view similar to what it used to be.

I surmise that this is not an intentional change to the way Eclipse operates and am therefore reporting this as a bug.

@howlger
Copy link
Contributor

howlger commented Jun 27, 2024

This regression might be related to the following part of code:

if (je.getElementType() == IJavaElement.IMPORT_CONTAINER || isInnerType(je)) {
setExpanded(i, false);

Note: This was first asked on Stack Overflow.

@iloveeclipse
Copy link
Member

@iloveeclipse
Copy link
Member

@Wittmaxi : could you please check?

@Wittmaxi
Copy link

@iloveeclipse If this issue is reported to the JavaOutlinePage, then there is probably something different going on here.

The bug reported in ui was referring to the ProjectExplorer using "setAutoExpandOnSingleChildPaths" of AbstractTreeViewer, yet I don't believe this view uses that feature.

I still need to check how to solve the other issue

@iloveeclipse
Copy link
Member

@Wittmaxi : I've just assumed that "Outline" as a "shared" view was also involved in the changes around eclipse-platform/eclipse.platform.ui#1072.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants