Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullity annotations on .api #121

Open
xenoterracide opened this issue Dec 14, 2024 · 0 comments
Open

Nullity annotations on .api #121

xenoterracide opened this issue Dec 14, 2024 · 0 comments

Comments

@xenoterracide
Copy link

xenoterracide commented Dec 14, 2024

Description

I notice that jgit's use of NonNullApi support is incomplete... specifically .api is not annotated and methods may return null.

This request is to annotate the api package.

Additionally it would be nice if you switched to or additionally included @Nullmarked either from jspecify or adding that annotation yourself

Motivation

Not having this prevents tools like errorprone with nullaway from working correctly. Also, adding Nullmarked is supported by nullaway for autodetection, where at the time of this writing NonNullApi is not uber/NullAway#1084 . In lieu of using Nullmarked I have to look at the source and then manually include/exclude subpackages that are marked.

Alternatives considered

No response

Additional context

I'd be happy to do a partial PR for the methods I know about, and add the NullMarked or include jspecify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant