Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an auxiliary such as
InstrumentControlAuxiliary
issuspend
ed thenresume
d, its channel has its methods_cc_close
, then_cc_open
called.The
CCTcpip
connector currently doesn't support that: once_cc_close
has been called,_cc_open
cannot be called anymore. This is becausesocket.socket
does not support reopening a closed socket.The changes here create the socket in
_cc_open
, allowing multiple_cc_open
/_cc_close
cycles.Relevant test (
tests/test_cc_tcp_ip.py
) has been updated, because it depended on using various methods ofCCTcpip
without first calling_cc_open
. This use case should not happen in the real world, and doesn't work anymore now that the socket is only created in_cc_open
.