Adress review comment and update tests

eclipse-kuksa · Nov 19, 2024 · d4c4941 · d4c4941
1 parent 3704194
commit d4c4941
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/databroker/src/grpc/kuksa_val_v2/val.rs b/databroker/src/grpc/kuksa_val_v2/val.rs
@@ -2356,7 +2356,7 @@ mod tests {
             .await
             .map(|res| res.into_inner())
         {
-            Ok(_) => {}
+            Ok(_) => {panic!("We shall not succeed with a blank before *")}
             Err(error) => {
                 assert_eq!(
                     error.code(),
@@ -2385,7 +2385,7 @@ mod tests {
             .await
             .map(|res| res.into_inner())
         {
-            Ok(_) => {}
+            Ok(_) => {panic!("Success not expected!")}
             Err(error) => {
                 assert_eq!(error.code(), tonic::Code::NotFound, "unexpected error code");
                 assert_eq!(

diff --git a/doc/protocol.md b/doc/protocol.md
@@ -23,7 +23,7 @@ This is an overview of the APIs supported described using the perspectives above
 | ------------------------ |-----|-----|-----|-----|-----|-----|-----|-----|-----|
 | gRPC (kuksa.val.v2)                     | Yes | Yes | Yes | No  | No  | No  | Yes | No  | Yes
 | gRPC (kuksa.val.v1) *Deprecated!*       | Yes | Yes | Yes | Yes | Yes | Yes | No  | No  | No
-| gRPC (sdv.databroker.v1)  *Deprecated!* | Yes | Yes | Yes | Yes | Yes | Yes | No  | No  | No
+| gRPC (sdv.databroker.v1)  *Deprecated!* | Yes | Yes | Yes | Yes | No | No | No  | No  | No
 | VISS v2                                 | No  | Yes | Yes | Yes | No  | No  | No  | No  | No
 
 In general it is possible to mix protocols in a deployment, as long as the difference concerning Target/Actuation values are observed.