Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdk22 OpenJDK StackWalker/CallerSensitiveMethod - Expected class jdk.test.CallerSensitiveTest but got [class java.util.CSM] #18696

Closed
pshipton opened this issue Jan 5, 2024 · 7 comments · Fixed by #18926 or #18967
Closed

jdk22 OpenJDK StackWalker/CallerSensitiveMethod - Expected class jdk.test.CallerSensitiveTest but got [class java.util.CSM] #18696

pshipton opened this issue Jan 5, 2024 · 7 comments · Fixed by #18926 or #18967
Assignees
@fengxue-IS
Labels
comp:vm jdk22 test failure
Milestone
Java 22 (0.45)

Comments

@pshipton
Copy link
Member

pshipton commented Jan 5, 2024 •
edited
Loading

https://openj9-jenkins.osuosl.org/job/Test_openjdk22_j9_sanity.openjdk_aarch64_mac_Personal_testList_0/1/
jdk_lang
java/lang/StackWalker/CallerSensitiveMethod/Main.java

16:04:08  ERROR: Expected class jdk.test.CallerSensitiveTest but got [class java.util.CSM]
16:04:08  java.lang.UnsupportedOperationException: Stack walker configured with DROP_METHOD_INFO
16:04:08  	at java.base/java.lang.StackWalker$StackFrameImpl.ensureMethodInfo(StackWalker.java:431)
16:04:08  	at java.base/java.lang.StackWalker$StackFrameImpl.toStackTraceElement(StackWalker.java:482)
16:04:08  	at java.base/java.lang.StackWalker$StackFrameImpl.toString(StackWalker.java:512)
16:04:08  	at java.base/java.lang.String.valueOf(String.java:5285)
16:04:08  	at csm/jdk.test.CallerSensitiveTest.lambda$checkNonCSMCaller$0(CallerSensitiveTest.java:147)
16:04:08  	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1709)
16:04:08  	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:782)
16:04:08  	at csm/jdk.test.CallerSensitiveTest.checkNonCSMCaller(CallerSensitiveTest.java:147)
16:04:08  	at csm/jdk.test.CallerSensitiveTest.invokeMethod(CallerSensitiveTest.java:111)
16:04:08  	at csm/jdk.test.CallerSensitiveTest.main(CallerSensitiveTest.java:73)

Perhaps related to #18697
@pshipton pshipton added this to the Java 22 milestone Jan 5, 2024
@pshipton
Copy link
Member Author

pshipton commented Jan 5, 2024

@keithc-ca

@pshipton pshipton mentioned this issue Jan 5, 2024
Closed
@babsingh babsingh mentioned this issue Jan 24, 2024
Merged
@tajila tajila added the comp:vm label Jan 29, 2024
@fengxue-IS
Copy link
Contributor

the cause of this is due to missing update to the walkState pointer allocated https://github.com/eclipse-openj9/openj9/blob/master/runtime/jcl/common/java_lang_StackWalker.cpp#L106 which allowed flags/data from previous walkState to be used during stack walking. I will open a PR to fix this shortly.

@fengxue-IS fengxue-IS mentioned this issue Feb 8, 2024
Merged
@keithc-ca keithc-ca mentioned this issue Feb 14, 2024
Merged
@keithc-ca
Copy link
Contributor

Tests to be unexcluded via adoptium/aqa-tests#5066.

@pshipton
Copy link
Member Author

Reopen since #18926 was reverted.

@pshipton pshipton reopened this Feb 15, 2024
@keithc-ca
Copy link
Contributor

@pshipton Do you think we should re-exclude the test, i.e. revert adoptium/aqa-tests#5066?

@pshipton
Copy link
Member Author

Yes, it would be nice to have clean jdk22 builds again.

keithc-ca added a commit to keithc-ca/aqa-tests that referenced this issue Feb 15, 2024
@keithc-ca
Re-exclude StackWalker/CallerSensitiveMethod/Main.java
1790418 
This reverts commit 63c7c9e.

eclipse-openj9/openj9#18926 was reverted and
eclipse-openj9/openj9#18696 was reopened.

Signed-off-by: Keith W. Campbell <[email protected]>
@keithc-ca keithc-ca mentioned this issue Feb 15, 2024
Merged
@keithc-ca
Copy link
Contributor

See adoptium/aqa-tests#5072.

JasonFengJ9 pushed a commit to adoptium/aqa-tests that referenced this issue Feb 15, 2024
@keithc-ca
Re-exclude StackWalker/CallerSensitiveMethod/Main.java (#5072)
2b50c63 
This reverts commit 63c7c9e.

eclipse-openj9/openj9#18926 was reverted and
eclipse-openj9/openj9#18696 was reopened.

Signed-off-by: Keith W. Campbell <[email protected]>
@fengxue-IS fengxue-IS self-assigned this Feb 15, 2024
@fengxue-IS fengxue-IS mentioned this issue Feb 16, 2024
Merged
@keithc-ca keithc-ca mentioned this issue Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengxue-IS fengxue-IS

Labels
comp:vm jdk22 test failure
Projects
None yet
Milestone
Java 22 (0.45)
4 participants
@fengxue-IS @tajila @keithc-ca @pshipton